feat(util): add more handlers to util.open #1786
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In WSL,
explorer.exe
should be checked ifxdg-open
isn't supported.Solution:
I thought of using
vim.ui.open()
, which allows for more flexibility if the user wants to override it like so:this way it would have a uniform behaviour across all
vim.ui.open()
invocations, and it would reduce the code duplication, butremembered that wouldn't work due to not being present in
0.8.*
.So updated the code to resemble the upstream
vim.ui.open()
implementation, increasing handler support.